search

AkarinVS / vapoursynth-plugin

My experimental VapourSynth plugin: (1) an enhanced LLVM-based std.Expr (aka lexpr), Select, PropExpr, Text and Tmpl. (2) DLISR. (3) DLVFX (4) CAMBI.
GNU Lesser General Public License v3.0
37 stars 8 forks source link

Expr: xor operator crashes VapourSynth #14

Closed Setsugennoao closed 1 year ago

Setsugennoao commented 2 years ago

Hello Akarin, I recently updated one of my functions substituting the old * 0 < with xor (#d9345df). Today, running a filterchain it crashed (can reproduce with this). After some debugging and wasting time isolating filters and functions used, I found out that the edited expr in contra_dehalo was the culprit xd

EDIT: Fwiw I'm using the latest build, with dynamic pixel access, though it shouldn't change stuff, I think?

AkarinVS commented 2 years ago

Interesting. The handling of and/or/xor are almost exactly the same, so it's very unlikely there are bugs that only affect xor but not and/or (which are used much more often). I tried a few cases, but couldn't reproduce the crash.

Could you please produce a minimal test case?

Thanks.

Setsugennoao commented 2 years ago

Hi! The weird fact is that I wasn't reproduce it without that video and filterchain, so there must be something very strange happening :/ Will look a bit more into it later, some months have passed, after all.

Setsugennoao commented 1 year ago

v0.96f seems to have fixed this, thanks!