Akavall / GoGamesProject

Trying to make some simple games using golang.
1 stars 1 forks source link

changed the url address to localhost #40

Closed Akavall closed 8 years ago

Akavall commented 8 years ago

Not a huge difference, but I think it is better to use localhosthere.

1) If we are to work with the code, we will probably have to change the code to use localhost anyway and test the changes locally first. With this pulll request we don't have to make any changes to do the testing. We would only need to change address in the production version.

2) There is no reason to display ip address. It is unlikely to be a security issue, but it is better to not display the ip address if we don't have too.

I still think that there might be a way to pass the ip address as a command line argument, but the biggest problem is that HTML does not have variables (at least I don't think it does). If this would possible we would not have to hard code the ip address.