AkhilNandhakumar / Guython

This website is a modified version of "flask_portfolio_hackers", which is a modified version of "flask_portfolio".
GNU General Public License v3.0
1 stars 4 forks source link

Week 6 Crossover Review - Create Task (Akhil & Jakub) #47

Open JakubPonulak opened 2 years ago

JakubPonulak commented 2 years ago

Rubric:

Code:

Review the code, see if it has comments, if comments explain what the code does well, if the code is organized, if it meets all the CB requirements.

Video:

See if the video meets all requirements, if it's not too long or too short, things that should be added or removed.

Responses:

Check if the responses answer the questions, if they're not too long or too short, if the screenshots match the requirements, anything they could add or should remove.


Links:

AkhilNandhakumar commented 2 years ago

Review of Jakub's Create Task

Reviewed by Akhil

Code:

I like the organization of the code. Keeping the data structures, in this case the dictionary, at the top of the code, followed by the functions, and then where the function is called. The comments throughout the code are detailed and easy to understand.

Video:

The video is short and sweet, and meets all of the college board requirements. I think at the very end of the video where you showed that you can search for multiple links, you could extend the video a bit, since it's only about 25 seconds long. If you can maybe try using I-movie or Shotcut to edit it to remove a bunch of the watermarks, but other than that its good.

Responses

I first checked whether the code met the parameter requirements, which it does. All of the responses fit within the word count limit, and most of them were concise. The only one that I would add to is the purpose, and explain what the website is about, and why a search bar was useful, for example, lots of links in the navbar and using a search bar is faster than clicking through the dropdowns.

JakubPonulak commented 2 years ago

Review of Akhil's Create Task

Reviewed by Jakub

Code:

Code looks neat and organized, includes comments for algorithmic section. Would like to see comments in HTML section, which would explain where the program is being called within the website. Maybe also add comments which explain the lists you included and the sections within them ("name", "url")

Video:

Video is easy to follow and shows all required parts of the program. It even included a different parameter, changing how the program functions, which isn't required by College Board. The only small thing I would change is small subtitles with some sort of background. At moments it was hard to read and they took up a significant part of the screen.

Responses:

Overall responses are clear, concise, and meet all requirements. It would be good if you explained the reasoning/background info about your program, because you didn't explain that it was for a website. Some responses seem a little short, make sure you meet the sentence requirements on CB (750).