search

AkhileshNS / heroku-deploy

A simple github action that dynamically deploys an app to heroku
MIT License
972 stars 254 forks source link

Could you release major version(s) of your GitHub action? #137

Open jmfayard opened 2 years ago

jmfayard commented 2 years ago

Bonjour! 🇫🇷

I contribute to GitHub Actions Kotlin DSL which provides an alternative to write GitHub Actions not in YAML but in a type-safe programming language: Kotlin.

To this end we provide type-safe wrappers for currently 72 (and counting) wrapper actions. Those type-safe wrappers are generated from its action.yml which we update when it goes to a new major version, for example actions/cache@v2 to actions/cache@v3

And of course we support your action as well!

Unfortunately when an action don't have a major version, which is what GitHub recommands, we are forced to update manually for every minor version, like from appleboy/scp-action/v0.1.2 to appleboy/scp-action/v0.1.3

See our issue here

Would you consider creating a major version for your action? That would make our life easier, and the life of your users easier in general.

You can find here the recommendations from GitHub:

https://github.com/actions/toolkit/blob/main/docs/action-versioning.md (see Recommendations in particular)

AkhileshNS commented 2 years ago

Hey @jmfayard, I will be releasing a major version pretty soon. It's been long overdue and should address many of the existing issues in the Action.

jmfayard commented 2 years ago

Note: in practice this is done by pushing a tag v1 to your latest 1.x.y release

git tag -fa v1 -m "Update v1 tag"
git push origin v1 --force
TheeMattOliver commented 2 years ago

Hey @jmfayard, I will be releasing a major version pretty soon. It's been long overdue and should address many of the existing issues in the Action.

Hi, this is great to hear, can you please include an argument to locate a Dockerfile in a subdirectory? I looked at source and couldn't find that.

jmfayard commented 1 year ago

🎉

Le ven. 17 juin 2022 à 19:49, AkhileshNS @.***> a écrit :

Hey @jmfayard https://github.com/jmfayard, I will be releasing a major version pretty soon. It's been long overdue and should address many of the existing issues in the Action.

— Reply to this email directly, view it on GitHub https://github.com/AkhileshNS/heroku-deploy/issues/137#issuecomment-1159107479, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADQFSD3E5I2PIMXT2BI6P3VPS3CZANCNFSM5ZCQ2O6Q . You are receiving this because you were mentioned.Message ID: @.***>