search

AkhileshNS / heroku-deploy

A simple github action that dynamically deploys an app to heroku
MIT License
972 stars 254 forks source link

Replace deprecated setOutput calls #157

Closed olivierlacan closed 1 year ago

olivierlacan commented 1 year ago

Should fix #156, setOutput was deprecated and will be disabled May 31st, 2023 which will lead to this action breaking or at least no longer outputing whether the deploy failed or succeeded.

I used the following as reference: GitHub Docs on Workflow Commands.

I would have used process.env.GITHUB_OUTPUT directly if it weren't for this example provided. Might still be fine to do this but it looks like this is roughly how the @actions/core package does this internally.

They wrap a lot more logic in an internal function that sadly can't (or shouldn't be) imported which is a bit of a bummer considering how simple this operation should be. But hey that's Node for ya.

olivierlacan commented 1 year ago

@AkhileshNS this should fix the last deprecation notice when running heroku-deploy in GitHub Actions:

image
olivierlacan commented 1 year ago

@AkhileshNS Could you review this? There's only a few months left before GitHub disables setOutput and it would be nice to give folks time to upgrade.

jerpint commented 1 year ago

is this going to be merged soon? Is this action still being maintained?

Romack commented 1 year ago

is this going to be merged soon? Is this action still being maintained?

This pull request should be closed as these changes are not needed... just need to uprev a package