AkhileshNS / heroku-deploy

A simple github action that dynamically deploys an app to heroku
MIT License
980 stars 258 forks source link

unable to deploy to Heroku due to ToS change? #160

Open zachokeeffe opened 1 year ago

zachokeeffe commented 1 year ago

A workflow which previously worked now fails. It seems to work but then fails after stating the terms of service have changed, and seeming to ask the user to open a browser to accept them:

Created and wrote to ~/.netrc Successfully logged into heroku › Warning: Our terms of service have changed: Added git remote heroku › https://dashboard.heroku.com/terms-of-service heroku: Press any key to open up the browser to login or q to exit: fatal: 'heroku' does not appear to be a git repository fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists.

It goes on to repeat the issue that heroku is not a git repository, with the main error being "Error: Error: Command failed: git push heroku main:refs/heads/main"

It seems to be able to log in with the justlogin: true. This action used to work, and the API key, app name, and email are in the yml file. Is it possible that it is failing due to the fact the the Heroku terms of service have changed, and it wants a person to manually log in, open the browser, and accept them?

xcfw commented 1 year ago

same happens for me

noushad-pp commented 8 months ago

@AkhileshNS : Any updates on this. I am also facing the same issue

my config

  deploy-staging:
    if: github.event_name == 'push' && github.ref == 'refs/heads/main'
    needs: build-and-test
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - uses: akhileshns/heroku-deploy@v3.13.15
        with:
          heroku_api_key: ${{secrets.GH_ORG_HEROKU_API_KEY}}
          heroku_app_name: unique-app-name
          heroku_email: heroku-email@email.com
          dontautocreate: true

errors:

Run akhileshns/heroku-deploy@v3.13.15
  with:
    heroku_app_name: unique-app-name
    heroku_email: heroku-email@email.com
    dontautocreate: true
    branch: HEAD
    dontuseforce: false
    usedocker: false
    docker_heroku_process_type: web
    delay: 0
    rollbackonhealthcheckfailed: false
    justlogin: false
Created and wrote to ~/.netrc
Successfully logged into heroku
 ›   Warning: Our terms of service have changed: 
 ›   https://dashboard.heroku.com/terms-of-service
Added git remote heroku
heroku: Press any key to open up the browser to login or q to exit: fatal: 'heroku' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: 'heroku' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

            Unable to push branch because the branch is behind the deployed branch. Using --force to deploy branch. 
            (If you want to avoid this, set dontuseforce to 1 in with: of .github/workflows/action.yml. 
            Specifically, the error was: Error: Command failed: git push heroku HEAD:refs/heads/main 
fatal: 'heroku' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

fatal: 'heroku' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: 'heroku' does not appear to be a git repository
fatal: Could not read from remote repository.
Error: Error: Command failed: git push heroku HEAD:refs/heads/main --force
fatal: 'heroku' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Please make sure you have the correct access rights
and the repository exists.

I have already accepted the TOS in dashboard. I can deploy using heroku-cli and similar .netrc file from local machine.

oswaldoacauan commented 8 months ago

@AkhileshNS any updates here?

I have some workflows that are working and others that are failing due the similar issue.