AkhileshNS / heroku-deploy

A simple github action that dynamically deploys an app to heroku
MIT License
974 stars 254 forks source link

Add multi image and dedicated dockerfile support #99

Open janz93 opened 2 years ago

janz93 commented 2 years ago

With the usage of --recursive it will be possible to push multiple Dockerfiles within one deployment. Additionally, it will be possible to create a dedicated production-ready Dockerfile suffixed with the process type.

closes #75 closes #81

ghostwriternr commented 2 years ago

Was using this action today in my project and this option is the only missing part. Would love to see this merged!

kiliw commented 2 years ago

I also came to the point where I need to specify a dockerfile. Would love to see this one merged too.

kiliw commented 2 years ago

Workaround: For now I just renamed the dockerfiles before the heroku action

// workflow.yml
jobs:
   build:
      runs-on: ubuntu-latest
      steps:
         - uses: actions/checkout@v2
         - name: 'Copy and rename dockerfile' # workaround 
           run: |
              mv Dockerfile.dev Dockerfile
         - uses: akhileshns/heroku-deploy@v3.8.8 # This is the action
           with:
              heroku_api_key: ${{secrets.HEROKU_API_KEY}}
              heroku_app_name: 'api' #Must be unique in Heroku
              heroku_email: ''
              usedocker: true
              # docker_heroku_push_recursive: Dockerfile.dev # TODO: Add once https://github.com/AkhileshNS/heroku-deploy/pull/99 is done