AkikoKumagara / discord-magic-update-linux

A script that magically updates your Discord linux version using the official .tar.gz download.
1 stars 0 forks source link

rm -rf #1

Open MNarath1 opened 2 months ago

MNarath1 commented 2 months ago

great script but from how i see it the way you delete the tarball with the -rf flags are redundant since neither are the files in question something protected that needs the force flag nor is this a directory where a recursive delete is necessary rm ~/Downloads/discord.tar.gz works perfectly fine and while it should still be fine since the path is thankfully static its always a bit scary to use rm -rf in a bash script

MNarath1 commented 2 months ago

otherwise greate little script currently adapting it to my usecase where it does not need any priviliges to run and stays completly inside the user directory

AkikoKumagara commented 2 months ago

great script but from how i see it the way you delete the tarball with the -rf flags are redundant since neither are the files in question something protected that needs the force flag nor is this a directory where a recursive delete is necessary rm ~/Downloads/discord.tar.gz works perfectly fine and while it should still be fine since the path is thankfully static its always a bit scary to use rm -rf in a bash script

Thanks for the heads up. I'll correct this ASAP.