Akimkin / autogroup

Firefox AutoGroup add-on
3 stars 1 forks source link

Enhancement: button to toggle AutoGroup On and Off #6

Open klint opened 10 years ago

klint commented 10 years ago

Hi Denis Often I find myself in a situation where I have some work to do on the web using various tabs to gather information from various sites in parallel. But with the autogroup feature activated, it happens that the pages go to another group when they are reloaded (I have tried using configuration, what that's not feasible in a handy way). Therefore I think that a simple button would be very useful, to toggle the Autogroup On or Off, which would keep its value across restart. When off, no autogroup rule would apply in any tab and FF would just behave like without the addon. When on, new URLs or next page reloads would use the autogroup rules again. Do you think that could be considered? Thanks Olivier

Akimkin commented 10 years ago

Hi, Olivier.

First (unrelated to the bug itself):

Here was some long excuse mentioning politics which I decided not to post. So...

Just sorry for long delay. But, what I should note about politics is that some of current events are happening in my city. There's a possibility that state of emergency will be declared in our region tomorrow. I don't know whether it will affect my work and/or network connection.

Now, to the bug. To be honest, I suffer from this too sometimes, just not too much, so I really didn't pay much attention. I just haven't found the "nice" way to fix this. Well, just turning filtering off may be such an idea, although I'd like to find some nicer solution if it exists. I don't want to give a false hope about terms and the time-when-I-will-implement-all-cool-features-right-way. So, I'm going create experimental branch for immediate feature merging where I'll merge your request on issue https://github.com/Akimkin/autogroup/issues/3. I think, button will go there too, although I'll need to read some docs on how to create it :). This branch probably won't be compatible with stable versions (e.g. on settings level), but at least I'll be able to deliver some features for testing in acceptable amount of time. When I'll rewrite feature "right way" so it could be considered ready for stable version, I'll put it to next release on Mozilla Addons.

Please, comment on this proposal. If it's acceptable and no other (related to our turmoil) problems happen, I'll create a branch with your commit tomorrow.

Cheers Denis

klint commented 10 years ago

Hi Denis Yes, I'm quite ok with the way you propose. I will be happy to test the experimental branch when it is available (I still running my own branch actually :). About another way to deal with our common last issue, I was also thinking about that: when a tab is moved manually from one group to the other in panorama mode, the addon could retain that the move was manual and keep any page opened from this tab in the same group (ie without applying the automated rules)...and the same for the new page opened from the manually moved page....And this should be kept between restarts. Do you see what I mean? Thanks again for your help and I hope you'll find your way in the turmoil. Cheers Olivier

2014-04-07 21:49 GMT+02:00 Denis Akimkin notifications@github.com:

Hi, Olivier.

First (unrelated to the bug itself):

Here was some long excuse mentioning politics which I decided not to post. So... Just sorry for long delay. But, what I should note about politics is that some of current events are happening in my city. There's a possibility that state of emergency will be declared in our region tomorrow. I don't know whether it will affect my work and/or network connection.

Now, to the bug. To be honest, I suffer from this too sometimes, just not too much, so I really didn't pay much attention. I just haven't found the "nice" way to fix this. Well, just turning filtering off may be such an idea, although I'd like to find some nicer solution if it exists. I don't want to give a false hope about terms and the time-when-I-will-implement-all-cool-features-right-way. So, I'm going create experimental branch for immediate feature merging where I'll merge your request on issue#3 (#3https://github.com/Akimkin/autogroup/issues/3). I think, button will go there too, although I'll need to read some docs on how to create it :). This branch probably won't be compatible with stable versions (e.g. on settings level), but at least I'll be able to deliver some features for testing in acceptable amount of time. When I'll rewrite feature "right way" so it could be considered ready for stable version, I'll put it to next release on Mozilla Addons.

Please, comment on this proposal. If it's acceptable and no other (related to our turmoil) problems happen, I'll create a branch with your commit tomorrow.

Cheers Denis

Reply to this email directly or view it on GitHubhttps://github.com/Akimkin/autogroup/issues/6#issuecomment-39774948 .

Akimkin commented 10 years ago

Hi again.

Yep, it obviously looks like the-way-it-should-work to me, but I'm afraid that Panorama doesn't have the underlying functionality for that. Although, I'll check again. It's been a while since I've read Panorama's source last time, but chance that such trick is possible is quite low.

As for branch, I'll add it at tomorrow's evening (my current time zone is EEST or UTC+3), it's a bit late here now :)

Cheers