updated for OF 0.8.0+ GLFW, added Fluxus Repl & File browser

danomatika commented 10 years ago

This is a Fluxus featureset improvement. Try it out before any merging is done. I basically added the Fluxus Repl (Read-Eval-Print Loop) aka console and the file browser as well as some customizations of both. The major changes are:

added prelim GLFW support (see note below), Glut support deprecated but can be used via defining OFX_GLEDITOR_GLUT
ALT-E: now executes the current script, ALT+R / ALT+0 which to the REPL (console)
removed current editor text and addTimestamp when saving (not that useful)
runScriptEvent is now executeScriptEvent
removed the save event since this is handled via the file dialog now
ALT-D: is now save as
ALT-S: now saves internally, opens save as if no file name has been set
saveFile and loadFile no longer have default filenames
ESC no longer exits the app since it is used to exit the file dialog
Fluxus classes which haven't been adapted or rewritten are now in src/fluxus so project files would need to be updated. (I did this for the Xcode project already)
a custom Logging class automatically pipes all ofLog prints to the Repl (minus headers)

Note: The biggest issue is the bug with keycodes in GLFW in OF 0.8.1. I have a hack in there for now but I'm not sure if this will work with a non-US keyboard. At the very least, I wanted to get something working until the fix comes with OF 0.8.2 and we can update it then. It seems like ALT may not work with GLFW in which case I'm thinking of changing the modifier key to CTRL. Thoughts?

See relevant key code here: https://github.com/danomatika/ofxGLEditor/blob/master/src/ofxGLEditor.cpp#L165

Akira-Hayasaka commented 10 years ago

Woa, this is super great update!! I really love this "save as dialog"...!

I agree with you, if the ALT is not working with GLFW, we will happily move to CTRL key. (I am not sure why I have chosen ALT key in the first place)

Since my keyboards is US, I did not tested it with non US keyborad. For this case, we will wait for the fix comes with oF082.

danomatika commented 10 years ago

Whoah. I hope you checked this out first ... I didn't intend to have it merged yet ...

Akira-Hayasaka commented 10 years ago

OK, I will ask someone to test it!

A

2014-06-11 10:09 GMT+09:00 Dan Wilcox notifications@github.com:

Whoah. I hope you checked this out first ... I didn't intend to have it merged yet ...

— Reply to this email directly or view it on GitHub https://github.com/Akira-Hayasaka/ofxGLEditor/pull/6#issuecomment-45691318 .

Akira Hayasaka

tell: +8190-1302-6606 mail: akira.hayasaka@gmail.com web: http://www.ampontang.com/ tumblr: http://ampontang.tumblr.com/ facebook: http://www.facebook.com/akira.hayasaka1 twitter: http://twitter.com/Akira_At_Asia

Akira-Hayasaka commented 10 years ago

Hey Dan,

I borrow JP keyboard and test it. And I find it is reasonable to limit the keyboard localization to US.

Yes, it does not work as JP keyboard layout (and apparently other language layout). But it works fine if we use JP keyboard as US keyboard layout. When JP people use non JP native app (e.g. blender, gimp etc.), It is usual that keep the US layout in mind and re-map the layout from JP to US in brain. I think it is weird habit, and you may think so too... That's why I do not use JP keyboard.

For example, ofxGLEditor remap "2"=>"@", but JP layout says "2"=>""". [image: 埋め込み画像 1] But we know "2"=>"@" in US layout, so we see """ as "@" when use the app which does not recognize JP layout (almost all of the apps in the world). I am not sure for other languages, but i think the situation will not change so much.

Seems it is possible to detect key layout. http://stackoverflow.com/questions/15907164/how-to-get-keyboard-layout-in-mac-with-c

I am hoping I can make other new addon for this key layout problem. It is useful to programmatically convert all key layout to US layout. e.g. ofxAnyKeyToUSLayout? :)

Thanks.

A

[image: 埋め込み画像 2]

2014-06-11 10:10 GMT+09:00 Akira Hayasaka akira.hayasaka@gmail.com:

OK, I will ask someone to test it!

A

2014-06-11 10:09 GMT+09:00 Dan Wilcox notifications@github.com:

Whoah. I hope you checked this out first ... I didn't intend to have it

merged yet ...

— Reply to this email directly or view it on GitHub https://github.com/Akira-Hayasaka/ofxGLEditor/pull/6#issuecomment-45691318 .

Akira Hayasaka

tell: +8190-1302-6606 mail: akira.hayasaka@gmail.com web: http://www.ampontang.com/ tumblr: http://ampontang.tumblr.com/ facebook: http://www.facebook.com/akira.hayasaka1 twitter: http://twitter.com/Akira_At_Asia

Akira Hayasaka

tell: +8190-1302-6606 mail: akira.hayasaka@gmail.com web: http://www.ampontang.com/ tumblr: http://ampontang.tumblr.com/ facebook: http://www.facebook.com/akira.hayasaka1 twitter: http://twitter.com/Akira_At_Asia

danomatika commented 10 years ago

Don't worry, it's already fixed for OF 0.8.2: https://github.com/openframeworks/openFrameworks/issues/2562

My manual mapping was just so that I could make it work until the next OF is released. I don't think we really need to deal with key mappings on our own.

Also, I know what you mean regarding keyboards. I've used both Swedish and German keyboards with the US mapping.

Akira-Hayasaka commented 10 years ago

OK, thanks. Then I will merge everything :)

Akira-Hayasaka / ofxGLEditor

updated for OF 0.8.0+ GLFW, added Fluxus Repl & File browser #6