search

Akirane / XIVHotbar

13 stars 9 forks source link

Field and Battle bars swapped with last update #7

Closed Noduko closed 4 years ago

Noduko commented 4 years ago

Hello there!

Thank you for updating this amazing addon.

It seems that the UI text for "1" (Field) and "2" (Battle) are swapped. When setting actions to the Battle hotbar (e.g. {'battle 1 1', 'ma', 'Head butt', 't', ''}), it'll be assigned to the "1" hotbar instead of the "2" hotbar.

Let me know if I'm just being confused or doing it wrong.

Akirane commented 4 years ago

Hello, I have changed the color ordering. Now the first environment is shown as "1" instead of "2". Are the environments also swapped for you?

tir. 11. aug. 2020, 20:37 skrev Noduko notifications@github.com:

Hello there!

Thank you for updating this amazing addon.

It seems that the UI text for "1" (Field) and "2" (Battle) are swapped. When setting actions to the Battle hotbar (e.g. {'battle 1 1', 'ma', 'Head butt', 't', ''}), it'll be assigned to the "1" hotbar instead of the "2" hotbar.

Let me know if I'm just being confused or doing it wrong.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Akirane/XIVHotbar/issues/7, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMOC3ULCJBSBCCIRVNI5TIDSAGFVVANCNFSM4P3LWZGQ .

Noduko commented 4 years ago

I just tried again and "1" is default hotbar and it displays "Battle" actions.

My confusion comes from this bit in the UI.lua:

    self.active_environment['field']:text('1')
    self.active_environment['battle']:text('2'

It says that "1" should be Field instead of Battle. I could rename Battle environment as "1" but I just wanted to report it in case this is not intended.