AkitaInteractive / Hachiko-Engine

A game engine built with love and care by Akita Interactive
MIT License
17 stars 0 forks source link

Improvement/beetle attack #457

Closed miquelmiro3 closed 2 years ago

miquelmiro3 commented 2 years ago

As @Bernatmago requested, now the beetles don't attack instantly they slow the attack animation down to give some anticipation to the attack. Also hitting the enemy makes it cancel its attack.

Please test it in depth thx.

Edit: to not open another pr i also emptied the player buffers on fall so if you fall and spam dash you dont fall again

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Bernatmago commented 2 years ago

As @Bernatmago requested, now the beetles don't attack instantly they slow the attack animation down to give some anticipation to the attack. Also hitting the enemy makes it cancel its attack.

Please test it in depth thx.

Edit: to not open another pr i also emptied the player buffers on fall so if you fall and spam dash you dont fall again

Thanks man, I will test now but it feels to me like attack should be cancelled when the enemy can not reach you only. What i meant is to make sure to give a bit of time when coming close to an enemy you werent fighting untill then so you dont get instantly hit.

EDIT: Lets leave it this way it feels better

VBoschMatas commented 2 years ago

Working on separating (actually @monikamnc is doing everything) the beetle attack sounds to fit the animation of the hit. Gonna update code once the sounds are okay