search

AkiyukiOkayasu / pacmog

PCM decoding library for embedded systems
Apache License 2.0
6 stars 3 forks source link

Panic when SSND chunk's offset and blocksize are non-zero #37

Closed AkiyukiOkayasu closed 3 weeks ago

AkiyukiOkayasu commented 1 year ago

https://github.com/AkiyukiOkayasu/pacmog/issues/33#issue-1881708527

it doesn't seem to support offset and blocksize in the SSND chunk (those fields are rarely used so probably ok)

In most cases, this will not be a problem, but it should be handled appropriately.

https://github.com/AkiyukiOkayasu/pacmog/blob/cf65111b8aeea6f32a47005f229f049d25afe4c6/src/lib.rs#L108-L109

AkiyukiOkayasu commented 3 weeks ago

Resolved in https://github.com/AkiyukiOkayasu/pacmog/pull/52 . But only not panic. offset and block_size of 0 are only supported. This is because most AIFF files are typically 0 and there is little need to support them.