search

AkkaNetContrib / Home

Akka.NET public public announcements and rules
8 stars 3 forks source link

Create a test adapter for MSTest V2 #6

Open alexvaluyskiy opened 7 years ago

alexvaluyskiy commented 7 years ago

https://www.nuget.org/packages/MSTest.TestFramework

dwalleck commented 7 years ago

Based on my limited understanding, this test adaptor should be an updated version of the original (https://github.com/AkkaNetContrib/Akka.TestKit.VsTest) MSTest adaptor. Is that correct?

Aaronontheweb commented 7 years ago

@dwalleck I think so - I don't really know enough about the new MSTest framework... But it makes sense that it'd be an evolution of our existing work with the Visual Studio testkit. What do you think though - does it merit its own NuGet package?

dwalleck commented 7 years ago

The reason I had mentioned the original MSTest was more from an example implementation perspective. From an API perspective it's similar, but my take from the wording of the MSTest V2 project is that is separate from the original MSTest. I think making a new project for this adapter would make sense. There doesn't seem to be any other takers for this item, so I'd love to dive in this week and see if I can get this done.

dwalleck commented 7 years ago

So after taking a look more at MSTest V2, it shares the essentially the same API as the previous version of MSTest. The only things that really change between the original VsTest package and MSTest V2 are which NuGet packages are included. With that in mind, I'm going to take a crack at keeping both versions in the same project, much like was done with the NUnit adaptor.

alexvaluyskiy commented 7 years ago

Good luck. If you need some help with our CI, just ping me.

dwalleck commented 7 years ago

Thanks! I opened a PR with the work I've done this weekend (https://github.com/AkkaNetContrib/Akka.TestKit.VsTest/pull/11). After doing my due diligence this weekend and finding out the old VsTest package can't be upgraded to .NET Standard, I'd like to suggest either making the MSTest adaptor it's own package or deprecating the VsTest adaptor in favor of the MSTest one. With the MSTestV2 NuGet package being a drop in replacement for the older VsTest/MsTestV1 assembly, it seems like supporting V2 would be enough going forward unless there's need for < .NET 4.5 support. I'm very open to feedback on how to proceed.

dwalleck commented 6 years ago

Per comments on my PR to the VsTest repo, I've created a new repo for just the MSTestV2 package: https://github.com/dwalleck/Akka.TestKit.MSTestV2 . I still need to add proper docs and an appveyor config, but I wanted to give a quick progress update so you all knew I was still working on this issue. I should be done in the next day.

alexvaluyskiy commented 6 years ago

@dwalleck Good news But you should setup AppVeyor only after movement of the project. Or you will do it two times :)

dwalleck commented 6 years ago

I'll take your advice about not setting up the CI twice :-) I think I've made all the necessary preparations to my repo. If this could be pulled into the AkkaNetContrib repo, I'll pick up on the CI work then.