Akkadu / styleguide

Developer styleguide for contributing to Akkadu repositories
https://akkadu.github.io/styleguide/
MIT License
0 stars 1 forks source link

[PROP]: Use request.js as our default way for any requests on the client side #9

Open TNieminen opened 4 years ago

TNieminen commented 4 years ago

Is your feature request related to a problem? Please describe.

Request.js is an Axios powered module written some time ago to normalise our request patterns on the client side. Things that the request.js provides:

In addition if we at any point want to extend this further, we can always split it into for instance sub classes. Also if we want to for whatever reason change axios to another module, we can do that without a major refactor.

Describe the solution you'd like

TNieminen commented 4 years ago

One possibility would be also to split this into "Akkadu_Components" as a installable module, this way we can also have versioning and maintain module specific in-detail documentation and just have a reference in the style guide.

HoukasaurusRex commented 4 years ago

Might be too early to separate into an npm module until we can use it elsewhere, but this is a good direction and I'd support a request wrapper we use for all client side requests