AkrilliA / laravel-beyond

Create Laravel classes in a domain driven way (insired by Spatie Laravel Beyond CRUD)
ISC License
219 stars 24 forks source link

v7.0.0-beta.x feedback #92

Closed regnerisch closed 5 months ago

regnerisch commented 1 year ago
regnerisch commented 1 year ago
alexanderkroneis commented 1 year ago
  • [x] Set --minimal as default on beyond:make:module
  • [x] Fix missing space on info: Action[modules/User/Domain/Actions/UserDestroyAction.php] created successfully.
  • [ ] Add autoregister for module service providers
  • [x] Add alias command for beyond:make:dto -> beyond:make:data

Why not replace beyond:make:dto by beyond:make:data? Since we are releasing a major version anyways and it's not breaking any existing code only how a Data Object would be created.

regnerisch commented 1 year ago

I replaced the default beyond:make:dto with beyond:make:data but added an alias beyond:make:dto. See https://github.com/AkrilliA/laravel-beyond/blob/84b4da223a555092a5ff550b8e9a910ee6a1c08d/src/Commands/MakeDataTransferObjectCommand.php#L12

With aliases we could also create short aliases for beyond: commands, e.g. b:m:model

alexanderkroneis commented 1 year ago

🫡 Good job man.

regnerisch commented 1 year ago
Wulfheart commented 1 year ago

Some issues I had:

  1. The beyond:make:module is missing in the docs and the --full option does not explain what it does.
  2. It would be nice to automatically place a .gitkeep folder in each directory when generating a module via --full as it would not be tracked in version control otherwise.
  3. Missing test generation commands
regnerisch commented 1 year ago
  1. --full creates all possible directories. (Yes docs should be provided)
  2. We should discuss this, as i prefer removing empty directories from my version control.
  3. As always: Feel free to add the command :)
regnerisch commented 11 months ago
regnerisch commented 11 months ago

@Wulfheart, Test generation is now supported: php artisan beyond:make:test User.UserTest

alexanderkroneis commented 11 months ago
regnerisch commented 5 months ago

Closed as we again changed how v7 will work. We try to release v7 next month.