AkrosAG / Akros-Marketplace

Apache License 2.0
3 stars 5 forks source link

The workflow for webcomponents are defined #253

Open akrguda opened 1 year ago

akrguda commented 1 year ago

As a developer I got the workflow for webcomponents defined and in use so the developer know the workflow. The current workflow shows linting and prettier issues as errors, when they should be shown as warnings as it happens in the main app. After correcting this, any other error should stop the building process and not deploy the app if on main branch.

DoR:

Aca:

Dod:

Ayerbe88 commented 1 year ago

Settings habe been changed to show prettier issues as warnings instead of errors. Code has been cleaned to not have linting errors nor warning in the webcomponents. New workflow is not necesary, what would be ideal would be to modify the frontend workflow including a new first step (before the build) which does the linting, not have the linting inside the build step, and make the build step depend on the success of the linting step. However, I was not able to achieve it, therefore the task is half complete.