search

Akryum / floating-vue

💬 Easy tooltips, popovers, dropdown, menus... for Vue
https://floating-vue.starpad.dev/
MIT License
3.34k stars 336 forks source link

fix: fix v-close-popper to function on mousedown #1014

Closed kouts closed 10 months ago

kouts commented 10 months ago

This PR fixes an issue #1013 where the v-close-popper directive wouldn't work after v5.1.

netlify[bot] commented 10 months ago

Deploy Preview for v-tooltip ready!

Name Link
Latest commit 01cf75f6dc87af0e8a1c50fe48e451227c39f099
Latest deploy log https://app.netlify.com/sites/v-tooltip/deploys/65a6660a5e237d0009761fad
Deploy Preview https://deploy-preview-1014--v-tooltip.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kouts commented 10 months ago

@Akryum, @antfu I managed to test this PR by directly editing the code inside node_modules/floating-vue/dist/floating-vue.mjs in my project since I wasn't able to build the dev environment (maybe the CONTRIBUTING.md file needs updating?).

This is the error that I get running pnpm run docs

image