Akryum / meteor-vite

MIT License
33 stars 16 forks source link

feat: Add testing suite to example app, fix bundler edge-cases with default exports, module links and relative wildcard exports #30

Closed JorgenVatle closed 10 months ago

JorgenVatle commented 1 year ago

Fixes

Additions

Vue Example App

For package development, I've added a client-side testing suite to the Vue example app to make it easier to determine what's working as it should. The terminal output is transmitted to the server so you don't need to exit your editor while testing. 👌

image

JorgenVatle commented 1 year ago

I'll go ahead and add a GitHub Actions workflow for validating that builds are at the very least passing. If you feel it's not a good fit, you should have write permissions on the branch to remove the workflow @Akryum 🙌

The pull request should be ready to be merged now. I've pulled the bundler into a fairly large project with a bunch of Atmosphere dependencies - and production builds appear to be working great. But I'm sure there's a list of other edge cases, not covered by my repo left to be worked out. 😅

Akryum commented 1 year ago

I guess this supersedes #28?

JorgenVatle commented 1 year ago

That is correct. 👍

red-meadow commented 1 year ago

@JorgenVatle , thank you very much for your effort! We are trying to use your fork in our app.

There is still at least one issue related to exports: this one. If you replace export { default as ReExportedDefault, other, subOther } from './other' with export * from './other', it doesn't break the app, but subOther cannot be imported from meteor/test:modules anymore.

JorgenVatle commented 1 year ago

I see! Thanks for the heads up. I'll try to find the time hopefully this or next week to look into it.

JorgenVatle commented 1 year ago

Alright, @red-meadow, so I've had quite a lot of time to work on this. Maybe a little too much to be honest. 😅

There's a little bit left to do in terms of refactoring and double-checking that there isn't something I've missed. It is functional however in case you want to try it out. 👍

38

red-meadow commented 1 year ago

@JorgenVatle , thank you very much! I'll test it ASAP.

JorgenVatle commented 1 year ago

It still hasn't touched a production environment yet, so there's bound to be some breaking issues. But the foundation is there and I don't imagine fixes being more than a line or two 👌 Do let me know how it goes 😄