Akryum / meteor-vite

MIT License
33 stars 16 forks source link

feat: πŸŽ‰ Upgrade Meteor package parser, stub validation and add Vitest #39

Closed JorgenVatle closed 10 months ago

JorgenVatle commented 1 year ago

This fork has its own release!

This fork of the Meteor-Vite bundler has been published as jorgenvatle:vite-bundler.

Changes

I've replaced most of the Regex we used to parse Meteor packages with a JavaScript parser to extract the data we need to build up Meteor stubs for Vite, this addresses most of the syntax-based edge cases caused by Meteor's package format.

It also makes it a lot easier to traverse through the bits of the package source we need to build up a good stub, all without having to worry about debugging and refactoring long lines of ungodly regex statements from the last PR. πŸ˜…

Testing πŸ§ͺ

Maintainability ℹ️

Fixes βœ…

Added 🎊

Akryum commented 10 months ago

Hey @JorgenVatle could you add me to the meteor-vite package on npm? Thanks!

JorgenVatle commented 10 months ago

I certainly can. πŸ‘

Though, this pull request has become a little dated since it was undrafted earlier this summer.

If it isn't too much work to review on your part, I would like to pull in the latest changes and fixes from the release branch of the fork. πŸ˜…

Akryum commented 10 months ago

We can do that after I merge this one

Akryum commented 10 months ago

@JorgenVatle Are you on Discord by any chance? I also invited you the repo if you want to contribute to it directly. :cat2:

JorgenVatle commented 10 months ago

Thank you for trusting me with this! πŸ™Œ

Yeah, I'm on Discord every now and then.

Akryum commented 10 months ago

Would you mind sending me an friend invite? Or send me your discord username by email