Closed JorgenVatle closed 10 months ago
Hey @JorgenVatle could you add me to the meteor-vite
package on npm? Thanks!
I certainly can. π
Though, this pull request has become a little dated since it was undrafted earlier this summer.
If it isn't too much work to review on your part, I would like to pull in the latest changes and fixes from the release branch of the fork. π
We can do that after I merge this one
@JorgenVatle Are you on Discord by any chance? I also invited you the repo if you want to contribute to it directly. :cat2:
Thank you for trusting me with this! π
Yeah, I'm on Discord every now and then.
Would you mind sending me an friend invite? Or send me your discord username by email
Changes
I've replaced most of the Regex we used to parse Meteor packages with a JavaScript parser to extract the data we need to build up Meteor stubs for Vite, this addresses most of the syntax-based edge cases caused by Meteor's package format.
It also makes it a lot easier to traverse through the bits of the package source we need to build up a good stub, all without having to worry about debugging and refactoring long lines of ungodly regex statements from the last PR. π
Testing π§ͺ
Maintainability βΉοΈ
changesets
Fixes β
Added π