search

Akryum / vue-virtual-scroller

⚡️ Blazing fast scrolling for any amount of data
https://vue-virtual-scroller-demo.netlify.app
9.36k stars 896 forks source link

fix: DynamicScroller should pass its own keyField prop to child RecycleScroller #732

Closed nicooprat closed 1 year ago

nicooprat commented 2 years ago

When using DynamicScroller, the keyField prop was ignored because it was manually set as its default value id here.

ryanpwaldon commented 2 years ago

Might need to bind the attribute for this one to work 😜

ryanpwaldon commented 2 years ago

That was fast. Not banking on a merge anytime soon tho 😆🤞

Akryum commented 1 year ago

I merged this PR too fast, it is expected that DynamicScroller hard code key-field to id.

I will revert this to fix #758

Akryum commented 1 year ago

Items passed from DynamicScroller to RecycleScroller are always of the shape { id, item, size }: https://github.com/Akryum/vue-virtual-scroller/blob/95b934a10343338d102324766e84036e06d9a6a6/packages/vue-virtual-scroller/src/components/DynamicScroller.vue#L115-L125

leochen-g commented 11 months ago

This issue has resurfaced in version 2.0, perhaps requiring another round of fixes.