search

Akryum / vue-virtual-scroller

⚡️ Blazing fast scrolling for any amount of data
https://vue-virtual-scroller-demo.netlify.app
9.36k stars 896 forks source link

feat: add skipHover prop to deactive the hover detection #752

Closed gans-groover closed 1 year ago

ishitatsuyuki commented 1 year ago

Are you sure that this actually fixes the performance issue? IIUC the problem is rerendering the entire list (as opposed to single item) on each hover update and having this prop doesn't avoid it, theoretically.

gans-groover commented 1 year ago

hi @Akryum could you please release this change as vue-virtual-scroller@1.0.11 ?

gans-groover commented 1 year ago

Are you sure that this actually fixes the performance issue? IIUC the problem is rerendering the entire list (as opposed to single item) on each hover update and having this prop doesn't avoid it, theoretically.

hi @ishitatsuyuki you are right, we don't use the hover class which is why disabling it altogether is easier for us. I'd gladly test your solution but we are still on Vue2.

ishitatsuyuki commented 1 year ago

Actually nevermind, the condition in event handlers avoids triggering the rerender altogether.

Since this was already merged let's keep skipHover for v1. For v2 we'll see if we still need the same workaround or we can just use the component wrapper to avoid rerender.

james-astra commented 3 weeks ago

Was this released? I cannot access the prop in the latest release on NPM and am having trouble building the source.