AkshDesai04 / PyCompare

This Python project aims to efficiently compare large datasets of images to identify duplicates
MIT License
1 stars 3 forks source link

feat: check if path folder given by user exists #26

Closed poneoneo closed 4 months ago

poneoneo commented 4 months ago

i think we should check folder path from user before to execute other part of script. also i think main.py should not have as much code as is have actually this should gather inside a function and move to anohter module. and just to finish. and also is a good practice to push on main branch only when the code is ready to use i means we should not see many comments like we are still testing for something.

AkshDesai04 commented 4 months ago

Makes sense I'm with u on pythons as less functional code in main.py as possible. About the multiple pushes to main.py, yes I agree with you here too. I had failed to maintain the stability of the main branch which is bad. Correcting that actively and working in branches; following a good structure and QOL practices. Will review the changes and merge once I'm at my desk. Currently AFK.

Thanks for the inputs 😄