search

AkshayChordiya / News

A sample News 🗞 app built using Modern Android Development [Architecture Components, Coroutines, Retrofit, Room, Kotlin, Dagger]
MIT License
848 stars 166 forks source link

Integrate with Dagger 2 #20

Closed Ezike closed 5 years ago

Ezike commented 5 years ago

Add dagger 2 for dependency injection. I'd like to send a pr for this soon

AkshayChordiya commented 5 years ago

Yes. I have implemented this and want to push. Just confuse if to merge it with current branch or create a seperate branch with dagger

Ezike commented 5 years ago

Hey Akshay, I sent a PR for the dagger implementations. I'm trying to get used to open source contributions 🙂 I'll love to get your honest feedback. Thanks

I also loved your article on architecture guidelines.

Ezike commented 5 years ago

🙂 Thanks for the assignment.

I was able to complete the implementation, I only hit an error with injecting viewmodel into the viewmodelprovider.factory class..

I'm following the dagger pattern as used in the GitHub browser sample by Google

AkshayChordiya commented 5 years ago

I'm following the same pattern. Why did you close the issue?

Ezike commented 5 years ago

Oh I think its a mistake or an error.. Let me reopen it