search

AkshayChordiya / News

A sample News 🗞 app built using Modern Android Development [Architecture Components, Coroutines, Retrofit, Room, Kotlin, Dagger]
MIT License
848 stars 166 forks source link

Two Incorrect Configurations found in app/build.gradle #25

Closed iNoles closed 4 years ago

iNoles commented 4 years ago

1) implementation "org.jetbrains.kotlinx:kotlinx-coroutines-test:$coroutinesVersion" needs to be testImplementation. As for right now, it is very unneeded libraries because it wouldn't break anything.

2) implementation "androidx.arch.core:core-testing:$lifecycleVersion" needs to be testImplementation too.

AkshayChordiya commented 4 years ago

Thanks for pointing it out. I recently noticed the same. I'll push fixes to both the issues in couple of days