search

AkshayChordiya / News

A sample News 🗞 app built using Modern Android Development [Architecture Components, Coroutines, Retrofit, Room, Kotlin, Dagger]
MIT License
848 stars 166 forks source link

Replaced Dagger with Koin #28

Closed annshsingh closed 4 years ago

annshsingh commented 4 years ago

In this, I have replaced Dagger with Koin. It is always good to have options and in my experience Koin is an excellent alternative to look into for your DI needs. The app is building and running as expected.

This is my first open source contribution, I tried to follow all the necessary guidelines. Do let me know if there are any issues :)

iNoles commented 4 years ago

It is best to do check Koin Dependency Graph Test on Unit Testing too.

AkshayChordiya commented 4 years ago

We decided to have parallel branch one with dagger and another koin and both will be parallel branches. Check #30 PR for more details