search

AkshayChordiya / News

A sample News 🗞 app built using Modern Android Development [Architecture Components, Coroutines, Retrofit, Room, Kotlin, Dagger]
MIT License
848 stars 168 forks source link

Suggerstion: Replace Gson with Kotlinx Serialization #31

Closed iNoles closed 1 year ago

iNoles commented 4 years ago

Gson is not really Kotlin friendly because it doesn't understand about Kotlin null safe types.

Moshi is made by Square and have kotlin support by codegen or reflect which requires kapt.

JetBrains made own json serialization library. https://github.com/Kotlin/kotlinx.serialization it have own compiler plugins for it.

AkshayChordiya commented 4 years ago

Yeah thanks for bringing this up. I'll try to do this sometime soon :)

nkrebs13 commented 4 years ago

I'd like to try my hand at this! I'll try to get a PR out this weekend at some point :)

AkshayChordiya commented 4 years ago

Thanks @nkrebs13. I'll assign the issue to you then :)