search

AkshayChordiya / News

A sample News 🗞 app built using Modern Android Development [Architecture Components, Coroutines, Retrofit, Room, Kotlin, Dagger]
MIT License
848 stars 166 forks source link

Migrated to View binding #49

Closed rohithThammaiah closed 3 years ago

rohithThammaiah commented 3 years ago

While working on the Compose News Detail screen Kotlin 1.4.10 was giving errors about Kotlin synthetic. So I had to resort to ViewBindings or wait until Kotlin 1.4.20(https://issuetracker.google.com/issues/166927559).

rohithThammaiah commented 3 years ago

* Where: Build file '/home/runner/work/News/News/app/build.gradle' line: 21 CI Pipeline breaks during the assignment of value to NEWS_API_KEY

iNoles commented 3 years ago

I think it is best to do View Binding because kotlin android extensions actually deprecated. https://youtrack.jetbrains.com/issue/KT-42121

AkshayChordiya commented 3 years ago

@rohithThammaiah Don't worry about the error on CI. It's an limitation of GitHub action where forks don't have access to the secrets which causes them fail. I have been looking for workarounds / solutions for quite some time now 😞