Keybindings redesign

[ThePhilgrim]

Currently, we can see the default keybindings in porcupine/default_keybindings.tcl and custom keybindings in keybindings.tcl in the config directory.

I would also appreciate a way to see all keybindings in a dialog window that could be opened from the menu, as well as configure specific keybindings there.

[rdbende]

New plugin? :D

[Akuli]

This is very different from how keybindings.tcl/default_keybindings.tcl work, but we could change that. I'm curious to know what @benjamin-kirkbride thinks about this, as he isn't a big fan of keybindings.tcl/default_keybindings.tcl.

[benjamin-kirkbride]

Very related to https://github.com/Akuli/porcupine/issues/1346

IMO this should be the requirements for keybindings:

• default keybindings should be able to be set against actions, programmatically
  • multiple presets of "default" keybindings should be possible. Example: querty, vim, dvorak, azerty, etc
  • where possible, we should copy default keybindings from VSCode because it is the most popular editor and what most people are familiar with. Especially for features that it has popularized, like the command palette.
• all keybindings should be able to be overridden with a config file
  • it should be possible to edit keybindings in a GUI, with those changes then being reflected into the config file
• it should be possible to query what keybindings are currently set along with their associated actions, both in the way conceived in this issue (a big ol' list), as well as where the actions appear:
  • the command palette (see bottom for how this could look)
  • menubar
  • hover tips/descriptions

  • etc

This is obviously a lot, and is drastically different from how things work today, but I think that implementing https://github.com/Akuli/porcupine/issues/1342 will make much of this way, way more feasible to implement.

---

[Akuli]

I like the plan :)

Querying is already possible, and works through virtual events. This is in Porcupine debug prompt:

>>> utils.get_binding('<<Menubar:Edit/Find and Replace>>')
'Ctrl+F'

[Akuli]

Another disadvantage with keybindings.tcl / default_keybindings.tcl is that the edits won't do anything until you restart Porcupine. There's no good way to fix this, because it is by design just a file that runs and adds the key bindings (and also does other things), without any support for later undoing what it does.