search

Akuli / porcupine

A decent editor written in tkinter
MIT License
144 stars 46 forks source link

"Quit" is never clickable in file menu #1422

Closed Akuli closed 4 months ago

Akuli commented 7 months ago

Introduced in #1349

taahol commented 6 months ago

https://stackoverflow.com/q/11828270/17635987

taahol commented 4 months ago

https://github.com/Akuli/porcupine/blob/d35e12e1163356fb1b2c9638efb8ed618690dcb5/porcupine/menubar.py#L298

Callback isn’t called when there is no tabs.

Akuli commented 4 months ago

IMO it should just pass a None to the callback when there are no tabs, so that the callback can decide what to do.