search

Akuli / porcupine

A decent editor written in tkinter
MIT License
144 stars 46 forks source link

right-click menu placing #1429

Closed Akuli closed 3 months ago

Akuli commented 7 months ago

2023-12-06-134224_1920x1080_scrot

The right-click menu appears exactly where the mouse is. This makes it easy to accidentally click the first menu item. It would be better to place the menu e.g. 10px below the mouse.

Porcupine has several right-click menus, and they should be all fixed at once. They all use the tk_popup() menu, so to find all places that need to be changed, you can search for tk_popup in the project (with e.g. git grep tk_popup).

Akuli commented 7 months ago

Maybe it would be good to also offset 10px to the right, because menus can also appear like this:

image

ethical-haquer commented 3 months ago

Noob question here, what is the proper way to create a pull request for an issue? I followed the directions for contributing, but once I have made changes on my fork, what is the proper way to create a pull-request for an issue? 😊 (Yes, it's my first time doing this)

Akuli commented 3 months ago

Nice to see you contributing :)

Put Fixes #1429 to the description of the pull request. The Fixes is a magic keyword for GitHub that links the pull request together with an issue, so that the issue closes when the pull request is merged.