right-click menu placing

Akuli / porcupine

A decent editor written in tkinter

MIT License

144 stars 46 forks source link

right-click menu placing #1447

Closed ethical-haquer closed 3 months ago

ethical-haquer commented 3 months ago

Added 10 pixels offset to right-click menus Fixes #1429

Akuli commented 3 months ago

The y offset is needed in situations where the menu shows near the right edge of the screen. For example, when right-clicking the text widget, this can happen and the menu should be placed below the cursor:

screenshot-1710091877

ethical-haquer commented 3 months ago

Thanks! A couple things:

* You missed one of the four menus. Run `git grep tk_popup` to find all places where menus are shown.

* These also need y offset.

Will do!

Akuli commented 3 months ago

IMO 10 pixels is better than 1 pixel. You got that part right initially. Sorry if I wasn't clear :)

ethical-haquer commented 3 months ago

Thanks! I tried it on my computer and the new behavior is awesome :)

Your welcome! I figured I had better start on something small. 🤣 Thanks for guiding me through the process and answering my numerous questions!