search

Akuli / porcupine

A decent editor written in tkinter
MIT License
143 stars 46 forks source link

Make sure that titlebar is black on all platforms #1506

Closed jhi2 closed 1 month ago

jhi2 commented 1 month ago

The titlebar is always black when the icon plugin is enabled

Moosems commented 1 month ago

Why would wanting the title bar and icon indicate that it should be black?

rdbende commented 1 month ago

Make sure that titlebar is black on all platforms

Sorry, it looks like the titleman package doesn't even load outside of Windows, so I don't know how this could work on all platforms.

Other than that, I don't think we want a custom titlebar in Porcupine. They are known to have all kinds of weird bugs on different window managers, including Windows.

jhi2 commented 1 month ago

In my next release of Titleman, I will make sure it works only on Windows. Sorry about that. I develop on Windows 11. Also, on manmy Linux distros and on Mac, it is already black.

From: Benedek Dévényi @.> Sent: Friday, May 17, 2024 12:25 AM To: Akuli/porcupine @.> Cc: jhi2 @.>; Author @.> Subject: Re: [Akuli/porcupine] Make sure that titlebar is black on all platforms (PR #1506)

Make sure that titlebar is black on all platforms

Sorry, it looks like the titleman package doesn't even load outside of Windows, so I don't know how this could work on all platforms.

Other than that, I don't think we want a custom titlebar in Porcupine. They are known to have all kinds of weird bugs on different window managers, including Windows.

— Reply to this email directly, view it on GitHubhttps://github.com/Akuli/porcupine/pull/1506#issuecomment-2116919796, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3V45HALZ4LOKFQVI2M6OH3ZCWWGZAVCNFSM6AAAAABH3BUAFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWHEYTSNZZGY. You are receiving this because you authored the thread.Message ID: @.***>

Moosems commented 1 month ago

It's not black on Mac unless you set the theme to dark mode. By default (light mode) it's white.

jhi2 commented 1 month ago

I will look into how to programacticly set that

From: Moosems @.> Sent: Friday, May 17, 2024 1:59 PM To: Akuli/porcupine @.> Cc: jhi2 @.>; Author @.> Subject: Re: [Akuli/porcupine] Make sure that titlebar is black on all platforms (PR #1506)

It's not black on Mac unless you set the theme to dark mode. By default (light mode) it's white.

— Reply to this email directly, view it on GitHubhttps://github.com/Akuli/porcupine/pull/1506#issuecomment-2118376422, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3V45HGC6GP47HT27UKSIDDZCZVUHAVCNFSM6AAAAABH3BUAFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYGM3TMNBSGI. You are receiving this because you authored the thread.Message ID: @.***>

Akuli commented 1 month ago

Thanks for contributing, but I'm not convinced that this is a good idea. What problem does it solve, and why do users need it?

jhi2 commented 1 month ago

style

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows

From: Akuli @.> Sent: Friday, May 17, 2024 6:55:16 PM To: Akuli/porcupine @.> Cc: jhi2 @.>; Author @.> Subject: Re: [Akuli/porcupine] Make sure that titlebar is black on all platforms (PR #1506)

Thanks for contributing, but I'm not convinced that this is a good idea. What problem does it solve, and why do users need it?

— Reply to this email directly, view it on GitHubhttps://github.com/Akuli/porcupine/pull/1506#issuecomment-2118576042, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3V45HBFCQV7VETLGKVW2BDZC2YIJAVCNFSM6AAAAABH3BUAFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYGU3TMMBUGI. You are receiving this because you authored the thread.Message ID: @.***>

Moosems commented 1 month ago

That should be a separate thing then.

Akuli commented 1 month ago

I'm still not convinced that this is a good idea. I will not accept code that messes with the title bar beyond setting text and icon.

jhi2 commented 1 month ago

What do you mean a seprate thing

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows

From: Moosems @.> Sent: Saturday, May 18, 2024 8:18:20 AM To: Akuli/porcupine @.> Cc: jhi2 @.>; Author @.> Subject: Re: [Akuli/porcupine] Make sure that titlebar is black on all platforms (PR #1506)

That should be a separate thing then.

— Reply to this email directly, view it on GitHubhttps://github.com/Akuli/porcupine/pull/1506#issuecomment-2118855265, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3V45HBIWI3ZQFGGKPFJPS3ZC5WLZAVCNFSM6AAAAABH3BUAFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYHA2TKMRWGU. You are receiving this because you authored the thread.Message ID: @.***>