Akuukis / sepraisal

Analyse and compare Space Engineers blueprints - either uploaded or browse 100k+ steam workshop items.
https://spaceengineerspraisal.net
GNU General Public License v3.0
2 stars 4 forks source link

some blueprints are rotated wrong #6

Open Akuukis opened 4 years ago

Akuukis commented 4 years ago

Summary

Some blueprints are rotated wrong both for thruster direction and in X-Ray

Steps to Reproduce actual behavior

See these examples:

  1. 1625401062
  2. This thread by MeriiFaerie:

    The forward/backward thrust numbers appear to be swapped for hydro: https://spaceengineerspraisal.net/analyse?steam=2104580017 This is my ship so I know it intimately, and it absolutely has 14.7 m/s2 thrust forward while empty with 2 large, 2 small hydro thrusters, not backward (5 small hydros).

    May be related to the thrust thing I noticed above: https://spaceengineerspraisal.net/analyse?steam=2069680721 Another one of my ships, and it has the turret on top, but the X-ray on the site shows the turret on the bottom (at least, that looks like the hitbox). I think there's something going on with the grid origin/a transform around the grid origin, but I'm not sure how I'd fix that so these show up right.

    Are you normalizing the rotation against the Main Cockpit/Main Remote Control or any cockpit/remote control on the grid? The reason I ask is that the grid pivot can be very different compared to the actual flight direction of the ship.

    https://drive.google.com/file/d/1yW9G3terqQm2OMpzWYqmO-wOo4yLt3Tt/view - Try that? I included 3 bps, the original ship with the backwards thrust, the new grid pivot as above, and the small ship that shows upside down.

Expected behavior

Every blueprints is rotated correctly.

Additional context

The problem is in Orientation class, which I know is buggy. Need more bad examples to pinpoint the bugs.

Please report blueprints you see rotated wrong!