Akylas / OSS-DocumentScanner

Android document document scanning app
https://www.akylas.fr
MIT License
607 stars 22 forks source link

[FEATURE REQUEST] Custom date format #177

Open nvllz opened 3 months ago

nvllz commented 3 months ago

Is your feature request related to a problem? Please describe. It's a problem that documents are named in a MM/dd/yyyy hh:mm am/pm format by default.

Describe the solution you'd like I'd prefer the ISO 8641 date format by default, which is more readable and universal when working with files. But a setting to pick from most popular formats would be a better solution.

joeldebruijn commented 2 months ago

Just saw this one, dont know if its since last update? image

Will test with 'iso' but maybe documentation about Y M D etc will follow?

joeldebruijn commented 2 months ago

Ah I see now, even picking 'iso' doesnt do anything (yet).

farfromrefug commented 2 months ago

@joeldebruijn it should! And the doc for other should be shown when you click the "here" text. Will check all.that Monday when i am back to work

joeldebruijn commented 2 months ago

Ah thanks, at the moment I have renaming scripts for the exported pdfs but eager to strip them away and have this right at the source. Not in a hurry tho, thanks.

farfromrefug commented 2 months ago

@joeldebruijn so i have tested the custom date format and all is working as expected. Dont forget to un check "use document name when possible". By default document name is set to the date with a custom format (we see it in your screenshot). So if you dont uncheck your custom format will never be applied. It is needed that way because you can change the document name, and i have to expect you want to use it if it is set.

joeldebruijn commented 2 months ago

Ah tested and indeed worked as intended after unchecking. Screenshot_20240507_153120_OSS Document Scanner.png

Thanks!

nvllz commented 2 months ago

@farfromrefug, you can see in the screenshot above that the file at the top is still named with a MM/dd/yyyy date format, so the issue should not be considered completed.

joeldebruijn commented 2 months ago

Sorry, just one more thing ... The ISO date/time takes the moment of export as a source, not the moment of scan?

Meaning: if I scan something on the day it came in, but export once a week or so, the dates are not the date the document is received ....

nvllz commented 2 months ago

You don't understand my point. I just want the name you see at the top of this screenshot to be in a format other than month-day-year, in my case yyyy-mm-dd. You can now set the export name format, but when you create a new document in the application, it's name will be in the unwanted format by default. Setting timestamp applies only to exported files, but not document names inside the app (screenshot above, top bar).

farfromrefug commented 2 months ago

@farfromrefug, you can see in the screenshot above that the file at the top is still named with a MM/dd/yyyy date format, so the issue should not be considered completed.

it is not the name of the file. It is the name of the document which is auto generated on document creation. But you are right i misread the issue as wanting custom name for file exporting, not document naming. Should i use the same setting for both?

nvllz commented 2 months ago

Not sure, but I personally think it would be more intuitive.

farfromrefug commented 2 months ago

@nvllz does not seem like a bad idea. Will do that and if i get requests for separated setting i ll do that then

farfromrefug commented 1 month ago

@nvllz actually was already there in the settings as a separate setting. But i forgot about it :s. I now refactored the settings and you should find the setting in the document naming section

nvllz commented 1 month ago

Thanks for your efforts! It works fine. The only thing I'd think about is fixing the capital "S" in the description of the "Document name date format" dialog, as it should be the lowercase "s". Also, the text says "You can find more here", but the label is not clickable.

farfromrefug commented 1 month ago

@nvllz thanks will.look at that the here should be clickable! Must a locale issue. What s your phone language ?

nvllz commented 1 month ago

It's English (UK).