search

Akylas / OSS-DocumentScanner

Android document document scanning app
https://www.akylas.fr
MIT License
607 stars 22 forks source link

[FEATURE REQUEST] Editing tools #197

Open Bertklq1 opened 2 months ago

Bertklq1 commented 2 months ago

Is your feature request related to a problem? Please describe. No

Describe the solution you'd like Editing tools

Describe alternatives you've considered No alternatives within the app

Additional context I am requesting following features

  1. Adjustment slider for adjusting brightness, contrast and color adjustment of applied filters ( for me, the "enhance" option seems to apply the contrast too much, so after applying the enhance option it would be better to adjust the intensity of the effects)
  2. An option/tool to erase the applied effect from specific part or area of the document ( currently, the "color" option seems to distort the color of the photo from my citizenship documents and other documents which i have tried. So after applying the "color" option, a tool to erase off the effect from that portion would be good)
farfromrefug commented 2 months ago

@Bertklq1 thanks for the report. 1/ enhance is quite a expensive algo. So adjusting its values would be quite expensive. However having brightness/contrast sliders for the "resulting" images is an option. will think about it. 2/ I understand the issue but this is a bit tricky. What you ask for would require a lot more complex data structure (and thus a big rewrite). Plus the UX part of it would be prettry tricky. So for now this seems out of scope.

BTW the color options was mostly there for cases where you have like a full red "document" with like a simple logo and the scanning would not get a good looking red card. This algo would make the card a single shade of red. It would never work for citizenship documents. Maybe a new algo would be needed. What are you trying to achieve?

Bertklq1 commented 2 months ago

I am trying to achieve filters equivalent to "light text" and "whiteboard" from adobescan in addition to post adjustment of the applied effects.

These options have worked well for me for scanning documents including citizenships.

farfromrefug commented 2 months ago

@Bertklq1 ok will try to see if i can test it. I dont like adobescan cause i have to create an account...

farfromrefug commented 1 month ago

@Bertklq1 i added brightness/contrast setting

Bertklq1 commented 1 month ago

Thanks for the great work really appreciate it. Hope the app gets adobe-like filter feature very soon

😊

farfromrefug commented 1 month ago

@Bertklq1 filters are tricky to implement. I started to search on the web for ideas but did not find much yet.