search

Akylas / OSS-DocumentScanner

Android document document scanning app
https://www.akylas.fr
MIT License
720 stars 26 forks source link

[FEATURE REQUEST] Undo image transformations #278

Open cd-FileX opened 1 month ago

cd-FileX commented 1 month ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] Image transformations are not undoable at once, but only for single pages.

Describe the solution you'd like A marker in the transform images dialog for the throughout selected option.

Describe alternatives you've considered An undo button.

Additional context Add any other context or screenshots about the feature request here. Related to #279

farfromrefug commented 1 week ago

@cd-FileX nnot sure why this would be needed. You can already "unselect" transformations. Maybe i am not understanding which transformations you are talking about

cd-FileX commented 1 week ago

About batch editing/transformation, so editing multiple images at once

farfromrefug commented 1 week ago

@cd-FileX ok i see now. Not sure how an undo would work. Not easy to implement

cd-FileX commented 1 week ago

I guess you would have to track which images were changed and what changes were made. Also, if there is not already one, you should save a config file or data of every image. Then you can take this data and mark the option in the multiple transformation dialogue. Else you could also just do it with a switch, so images which have the transformation but the switch is toggled off, get the transformation removed. The other way around if it is turned on the transformation in being added.

farfromrefug commented 1 week ago

I guess you would have to track which images were changed and what changes were made. Also, if there is not already one, you should save a config file or data of every image. Then you can take this data and mark the option in the multiple transformation dialogue. Else you could also just do it with a switch, so images which have the transformation but the switch is toggled off, get the transformation removed. The other way around if it is turned on the transformation in being added.

Yes i would have to track more history for image because of consecutive changes. I dont think it is worth it. Hope you understand

cd-FileX commented 6 days ago

I understand it too well that it's a lot of work. But if you could implement that switch thing I mentioned before, that would also solve this problem.

farfromrefug commented 6 days ago

@cd-FileX i dont sée what it would solve. There is never a case where an image is marked as transformed while not being transfromed, or the contrary. Even when it crashes! I am.sorry i dont sée what the issue really is except from the crash. You can always untransform images by selecting transform images and do it with all unselected