Akylas / OSS-DocumentScanner

Android document document scanning app
https://www.akylas.fr
MIT License
695 stars 24 forks source link

[FEATURE REQUEST] parallel crop adjustment #91

Closed S-Joao-V closed 2 months ago

S-Joao-V commented 7 months ago

Hello, great app so far, have been using weekly usage in different situations!

In the same view as this issue: https://github.com/Akylas/OSS-DocumentScanner/issues/81

It would be good to have "parallel" handles to adjust both corners at the same time. In my experience, if you already have your camera aligned with the page to be scanned, but if the automatic corner detection does not work, the proper crop would be quickly set by adjusting one or more sides of the crop area.

Other camera/scan apps have a similar side handle other than just in the corners.

farfromrefug commented 7 months ago

@S-Joao-V do you have an example video or something so that i can see how others do that?

S-Joao-V commented 7 months ago

odrive like this in onedrive, each "handle" moves both corners at the same time, even snapping to the inner borders of a page/table/picture within a page. Samsung camera, after taking a picture as a scan, allows this too, but without the visual cue, dragging the edge of the crop area moves both corners at the same time.

farfromrefug commented 7 months ago

ok I sée now but what if the 2 bottom corners are not at the same y? I mean if the detected document is not rectangular it won't work

blaueente commented 7 months ago

at least office lens then assumes a perspective distortion and moves the edge such that it stays parallel on the paper. Quite handy: adjust the corners that are visible in the images to correct for perspective distortion, then then "parallel move" the edges to select the actual crop.

farfromrefug commented 7 months ago

@blaueente OK I ll start to think on how to do this best

farfromrefug commented 2 months ago

@blaueente it is now implemented