Akylas / oss-weather

An OSS weather app for iOS/Android
MIT License
162 stars 13 forks source link

Wrong icon for snow shower (rain shower instead of snow shower) #125

Open Jerome-Herbinet opened 4 months ago

Jerome-Herbinet commented 4 months ago

Hi,

First, your app is great ! Thanks for the Job :-) I notice that the icon used for snow showers is the one used for rain showers. Could a more appropriate icon be used? I live in the French Alps and when you look at these icons, you think it's only rain that's going to fall, when it's actually snow that you should expect.

Best regards.

Below, weather forecast for a ski resort. When touching the icons with sun / cloud / rain ... it indicates "Averse de neige" which doesn't fit the icon. Screenshot_2024-03-06-09-33-45-814_com akylas weather

farfromrefug commented 4 months ago

@Jerome-Herbinet you are 100% right :D and this is because the icons i use dont have the snow shower icon :D I am no designer so i used only what i found :D I need to find a new icon set to fix that kind of issue.

Will fix it!

Jerome-Herbinet commented 4 months ago

@farfromrefug thanks for your reply ! 🙂 As a suggestion, couldn't you call the 4802 icon for sown showers instead ? (if technically possible, as a workaround before using a new icon set) 2024-03-06_11-48

farfromrefug commented 4 months ago

@Jerome-Herbinet sure i can! Thanks i will use that

Jerome-Herbinet commented 4 months ago

@farfromrefug that's great if you can do so 🙏 ! Please pay also attention to the equivalent context by night 🙂

farfromrefug commented 4 months ago

@Jerome-Herbinet i wont. it will be a bit trickier than i thought because i use the icon list from https://openweathermap.org/weather-conditions#Weather-Condition-Codes-2 which does not support this directly. Will have to rewrite my icon system (it was coming anyway) so bear with me for a little bit ;)

0-5-0 commented 4 months ago

Semi related but you had also made a new icon for the forecast list at the bottom which was showing the snow one for mixed precipitation. I'll close the cm/mm issue (https://github.com/Akylas/oss-weather/issues/90) since this thread is a better fit. 307548139-deba3c9b-158e-4281-b474-d9682c2adc9c

farfromrefug commented 3 months ago

@Jerome-Herbinet @0-5-0 should be fixed in latest

0-5-0 commented 3 months ago

I'm having a hard time finding cities with mixed precipitation, snow/rain.. I found Reykjavik Iceland which on Friday shows the water drop icon in the list next to the UV symbol but snow cloud on the right larger icon and weather forecast is "light snow". Also Les Saisies France which shows Snow Shower again on Thursday, water drop symbol and snow cloud with "snow shower".

Should it be showing the mixed precipitation symbol/clouds? This is happening on all 3 icon sets, thanks for making it selectable too, that's absolutely awesome :), they look great.

Sorry just noticed I was testing with GFS Seamless, I guess depending on the model they might provide different wording in the predictions? Maybe this throws things off. Les Saisies using ECMWF 0.25 on Friday shows Snow shower, with snow cloud, if snow shower is the same as mixed precipitation/rain and snow.

farfromrefug commented 3 months ago

@0-5-0 think it would be best to test with météo France I am sure it should give mix of snow/rain I have to apply some rules to when to actually show it. like if rain/snow represents only a few percents I only show the other one.

I am also seeing some very weird numbers in Open Météo around precipitation/rain/snow/showers that I reported there

0-5-0 commented 3 months ago

Ok, looking at Reykjavik using Meteo France (their API) and OpenWeatherMap does show the mixed precipitation clouds but no mixed precipitation symbol.

Doing the same thing with any of the Open-Meteo models always shows something else, there's just no mixed precipitation. I'm not sure if that has to do with them using different wording. It seems like in some cases they print "snow showers" for days Meteo France and OpenWeatherMap write "rain and snow", snow showers basically being heavy/quick snow falls from what I could gather.

Hopefully Open-Meteo is able to look into the issues you mentioned.

farfromrefug commented 3 months ago

@0-5-0 will run some more test. But indeed right now there is almost no precipitations anywhere in the world :s and especially not at relatively high altitudes