Akylas / oss-weather

An OSS weather app for iOS/Android
MIT License
161 stars 13 forks source link

Chart display switches #195

Closed TenchMaviatorius2759 closed 1 month ago

TenchMaviatorius2759 commented 1 month ago

I have a suggestion. First of all, I wanted to ask. Is it supposed to be that the options "Force charts to show in landscape" and "Charts use full height in portrait" can be enabled simultaneously? In this case, only one function will work. I would like to make them mutually exclusive, meaning that turning on one of them turns off the other and vice versa, to avoid confusion. Screenshot_20240603-210951_OSS Погода

v2.5.0.124 Android 13

farfromrefug commented 1 month ago

@TenchMaviatorius2759 I see what you mean. The thing is you need to see it that way:

I do understand your point though as indeed they cant be both used together (well auto landscape will take over and thus the other one is useless), however i dont think it hurts to have both enabled at the same time, and as i mentioned before it prevents unwanted behaviors.

is that ok with you? I am open to still change the behavior

TenchMaviatorius2759 commented 1 month ago

@farfromrefug understood, thank you for the explanation.

is that ok with you? I am open to still change the behavior

You can leave everything as it is.