search

Akylas / oss-weather

An OSS weather app for iOS/Android
MIT License
225 stars 14 forks source link

Map animation is a touch too fast #227

Open Mrnofish opened 1 month ago

Mrnofish commented 1 month ago

The map animation is a touch fast for my tastes, it makes interpreting the movement of the rain cells harder than it needs be. Would it be possible to perhaps add some way to customize the speed?

farfromrefug commented 1 month ago

@Mrnofish sure i ll make it configurable!

farfromrefug commented 4 weeks ago

@Mrnofish it is now implemented

cb8121 commented 3 weeks ago

Hi, after the Implementation in v2.8.1 the map isn't working any more. Screenshot_20241029_104134_OSS Weather

farfromrefug commented 3 weeks ago

@cb8121 really sorry. Will fix it

Mrnofish commented 3 weeks ago

FWIW it's working for me. There is some room for small improvements (e.g. the slider setting a delay value instead of a speed? thus apparently working the opposite that one would expect) but it's fine otherwise, thanks for taking care of it.

(I'm leaving this open since it's being used to track the regression.)

farfromrefug commented 3 weeks ago

@Mrnofish indeed the animation speed is defined by a delay. Would it be better to have a speed like with default to 1 and the going slower (0.5) or faster (1.5) ?

Mrnofish commented 3 weeks ago

Since the proposed scale would be completely arbitrary (real time not being a useful option), it would come down to the tuning.

What I was pointing out, is that a slider labeled "speed" intuitively associates bigger numbers to higher speeds, whereas now it works in reverse (in fact sliding to the right, which is generally associated with higher/louder/faster/etc, causes the animation to slow down instead.)

I can certainly live with the way it is, though, and simply renaming the slider so that it's consistent with its function would probably be okay for most.

farfromrefug commented 3 weeks ago

@Mrnofish yes i agree it is not ok as it is. I will change it to some arbitrary "speed factor" (1 being the default)

cb8121 commented 1 week ago

Hi, after the Implementation in v2.8.1 the map isn't working any more. Screenshot_20241029_104134_OSS Weather

Hi, even after updating to v2.8.2 I can't see the map. Same Error Message.

farfromrefug commented 1 week ago

@cb8121 I am.sorry I can't see what s happening. Was it working before ? Where did you install it from ? Maybe you could share a logcat?

cb8121 commented 1 week ago

Yes, it was working prior to v1.8.1 Unfortunately I have no idea how to provide a logcat. I always used the play store version but with your question in mind I just tested the APK from GitHub and see: the map is working with this version! Nevertheless, would be nice to have the play store version working (again).

farfromrefug commented 1 week ago

Yes, it was working prior to v1.8.1 Unfortunately I have no idea how to provide a logcat. I always used the play store version but with your question in mind I just tested the APK from GitHub and see: the map is working with this version! Nevertheless, would be nice to have the play store version working (again).

Interesting! will try to play store build and report to you