search

Akylas / oss-weather

An OSS weather app for iOS/Android
MIT License
188 stars 13 forks source link

Mfprovider add missing null checks #61

Closed baltevl closed 1 year ago

baltevl commented 1 year ago

Found some null and undefined values while testing and fixed them. Please have a look at the default values used in these cases. I'm not a hundred percent sure if those are right

farfromrefug commented 1 year ago

@baltevl the change at line 324 is not needed. Plus we dont want an empty string if no value. Having null/undefined allows to hide widget if no data (in general not sure about this case)

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication