search

Al-Murphy / MungeSumstats

Rapid standardisation and quality control of GWAS or QTL summary statistics
https://doi.org/doi:10.18129/B9.bioc.MungeSumstats
75 stars 16 forks source link

Add tests for `get_genome_builds` #59

Closed bschilder closed 3 years ago

bschilder commented 3 years ago

Added, but not for is_32bit_windows. Here: https://github.com/neurogenomics/MungeSumstats/blob/bschilder_dev/tests/testthat/test-get_genome_builds.R

and here: https://github.com/neurogenomics/MungeSumstats/blob/792a5b52cd53be101feda691998d4b685dac4996/tests/testthat/test-validate_parameters.R#L160

bschilder commented 3 years ago

These tests may or may not add too much time to the overall build process. Will check that everything still builds under 15m

bschilder commented 3 years ago

We're at 15m 27s. So close! I'll hash out these tests to get us back under 15

bschilder commented 3 years ago

However, I am keeping this test, since I think it's important we include at least one test that infers the genome build:

https://github.com/neurogenomics/MungeSumstats/blob/bbbb5b8f119199197e2060db03b1812c8c4bd245/tests/testthat/test-validate_parameters.R#L163