Al-Qa-qa / dyad-private-audit

4 stars 1 forks source link

Audit Recap #12

Open Al-Qa-qa opened 3 months ago

Al-Qa-qa commented 3 months ago

Post-audit (mitigation process) has been finished.

Issues Summary.

ID title status
H-01 Free DYAD can be existed without collateral because of partial liquidation edge case Resolved
H-02 Upgrading process uses initialize instead of reinitialize modifier Resolved
M-01 Liquidation process will get Dos'ed if tvl falls below DYAD::totalSupply Resolved
M-02 Partial Liquidation Bonus is set wrongly Acknowledged
M-03 DeployVaultManagerV3 compilation will fail as encodeCall() expects two args Resolved
L-01 Single-step ownership transfer mechanism by OwnableUpgradeable Acknowledged
L-02 The new liquidation implementation does not round in the favour of the liquidator Resolved
I-01 mappings key/value support names, no need to comment them Acknowledged