search

Al-Qa-qa / dyad-private-audit

4 stars 1 forks source link

[H-02] issue `H-07` in Code4rena contest did not fix #4

Closed Al-Qa-qa closed 5 months ago

Al-Qa-qa commented 5 months ago

This issue introduced when mitigation issue H-07 from code4rena contest

Description

The HIGH seventh issue in code4rena contest, which stated that the liquidation only happen if the CR goes below 150%, and this is not the only invariant to check. There is another invariant which is the exogenous collaterals should be at least 100% of the CR.

The issue was introduced by code4rena Auditors and it was confirmed by the Judger as a HIGH issue, and the sponsor confirmed it too, here. There was some misunderstanding between this issue and the issue H-09, And The sponsor thought that fixing issue H-09 would fix issue H-07, but this is not true.

To not rewrite the issue again, the issue writeup is here. and the mitigation review will be the same as stated in Code4rena issue report.

Al-Qa-qa commented 5 months ago

Although this issue was a HIGH accepted issue in C4 audit. the documentation said that the only condition to liquidate a position is CR goes below 150%. which means it is a design choice. So I will make the issue Invalid.