Fix progress bar - Githubissues

AlJohri / docx2pdf

MIT License

506 stars 96 forks source link

Fix progress bar #32

Open austin-ultratesting opened 3 years ago

austin-ultratesting commented 3 years ago

resolve_paths(input_path, output_path) has an else statement which does not close the tqdm progress bar pbar.

The proposed fix is to:

close it once the pbar.update() method is called.
In addition, for ease of output, pbad has a description which takes the last portion of the path so it displays the progress conversion of the pdf file.

AlJohri commented 3 years ago

Thanks @austin-ultratesting! Nice catch. Can you double check if from ntpath import basename is cross OS compatible? I've generally used pathlib for these kinds of things: https://docs.python.org/3/library/pathlib.html

After that, this LGTM!