search

AlUlkesh / stable-diffusion-webui-images-browser

an images browse for stable-diffusion-webui
629 stars 110 forks source link

"All" tab knock-on bug fix #200

Closed Ezekiel-Rage closed 1 year ago

Ezekiel-Rage commented 1 year ago

The addition of the All tab introduced a bug in which an "All" folder is created in the root stable diffusion webui directory. This PR attempts to address that.

In addition I'm investigating a second knock-on bug where the user clicks the "open folder" button on the All tab and nothing happens. This seems logical when viewing the image index page since no specific folder is selected. What should happen if the user has an image selected? I'd expect the folder to be read from the base path of the image but wanted to be sure that's the behavior you expect.

AlUlkesh commented 1 year ago

Yes, that's also what I would expect. However what should happen when no image is selected yet? The button should probably not be displayed then?

AlUlkesh commented 1 year ago

Can you change if not os.path.exists(dir_name) and os.path.basename(os.path.normpath(dir_name)) != "All": to if not os.path.exists(dir_name) and tab.name != "All": Keeps it a little simpler.

Ezekiel-Rage commented 1 year ago

I made the suggested change in syntax. I need to investigate more to determine the best way to handle the button when an image is selected. I've disabled it entirely for now on the all tab since it's non-functional.