AlUlkesh / stable-diffusion-webui-images-browser

an images browse for stable-diffusion-webui
629 stars 110 forks source link

[Bug] Sidebar items aren't hidden/removed even though option is set in settings #229

Closed robonxt closed 1 year ago

robonxt commented 1 year ago

First off, thank you for making this extension! It's really helpful to manage and look for previous generations!

Per the title, I'm having issues where I set several items in the "hidden components" settings, however certain items are not being removed from the UI.

My settings in the config.json file:

"image_browser_hidden_components": [
    "Sort by",
    "Filename keyword search",
    "Ranking Filter",
    "Aesthestic Score",
    "Open Folder",
    "Copy to directory",
    "Ranking Bar"
],

The result: image

AlUlkesh commented 1 year ago

Thanks!

I looked at the code... and I think this never worked. Either that or there was a fundamental change in Gradio, that affected this.

Currently only the elements that get hidden/shown depending on if you are on the thumbnail overview or the image view (like delete) get hidden.

I'll try to implement a version that works for the remaining fields.

robonxt commented 1 year ago

It used to work, prior to 2 weeks ago. My gradio is still on the default 3.32.0 (it hasn't changed for a while), so I don't think it's gradio issue, unless something changed in the webUI itself.

AlUlkesh commented 1 year ago

That's great, that you remembered it worked 2 weeks ago for you, still.

With this timeframe I was able to pinpoint the issue. It was a completely unrelated change, that was supposed to be purely visual.

Does the new commit work for you?

robonxt commented 1 year ago

Yep! It's working now. Thanks for the quick fix!