AlUlkesh / stable-diffusion-webui-images-browser

an images browse for stable-diffusion-webui
623 stars 111 forks source link

images not displaying properly #230

Closed Kapowpenguin1 closed 1 year ago

Kapowpenguin1 commented 1 year ago

since commit a3aeb93, image browser displays images like this image instead of this image is this supposed to happen? and if not, is there something i should do to fix it? i'm running on webui commit 22bcc7be, but it seems happen in the latest webui commit too

AlUlkesh commented 1 year ago

Hmm, doesn't happen for me.

Which Gradio version are you running?

And how is that setting set for you:

image

Kapowpenguin1 commented 1 year ago

i'm on 3.32, so i'm guessing that toggling it wouldn't work either way [i tried anyways, and as expected, it doesn't seem to do anything]. i'm not sure how to upgrade gradio tho

AlUlkesh commented 1 year ago

Yes, 3.32 with the box not ticked should work.

Can you post a complete debug log (from starting a1111 until the error happens), as described here: #130

Kapowpenguin1 commented 1 year ago

image_browser.log

AlUlkesh commented 1 year ago

Are there no javascript logs? Did you press the Get Javascript Logs button?

Kapowpenguin1 commented 1 year ago

i'm not seeing any useful javascript logs. pressing "Get Javascript Logs" just populates the text box with 2023-08-26-07-12-33 image_browser.js: image_browser_turnpage:start 2023-08-26-07-12-33 image_browser.js: image_browser_turnpage:end and creates a log file for image_browser.py

Kapowpenguin1 commented 1 year ago

this still seems to happen even when i force the webui to use a newer gradio version [3.41.2] by changing the "requirements" files. but for the latest webui commit and gradio 3.32.0, the images still don't display properly, but differently https://github.com/AlUlkesh/stable-diffusion-webui-images-browser/assets/12951389/327b8141-ad50-4a40-9f3b-65ce9a20d38a first example is webui commit c9c8485 with gradio 3.32.0, second example is webui commit c9c8485 with gradio 3.41.2, both examples of "Use automatic height" checked

AlUlkesh commented 1 year ago

Can't see anything odd in the log. I take it that is only set from your recent testing, as it should be off for your Gradio version: "image_browser_height_auto": true,

I now tried out several versions and branches of a1111, but can't replicate it.

You can try to temporarily disable every other extension and restart a1111, to see if some interaction could be the problem.

Kapowpenguin1 commented 1 year ago

i had a fresh, test install of the webui i used as a reference, and image browser on that one worked fine, so i started messing around with my bugged install and reinstalling stuff. i installed a newer version of torch [from 1.13.1 to 2.0.1] and a newer version of xformers through commandline flags, then uninstalled and reinstalled gradio through pip. i'm not sure which of those changes made a difference, but image browser images seem to be displaying... relatively properly again. the gallery goes further than i'm used to, but i'm assuming that's intentional for reference, gallery previously image vs gallery now image

edit: after further experimentation, it seems like explicitly

is what specifically helps

after even more experimentation, it seems like an extension i was using [canvas zoom] was in fact the one causing me problems. i ran a git pull update on it and everything works fine now [once i reinstalled gradio after]

AlUlkesh commented 1 year ago

Thanks for letting me know in detail. That always helps if something similar comes up.

BTW... which model/lora are you using in your screenshots?

Kapowpenguin1 commented 1 year ago

those generations specifically were with abyss orange mix 2_hard [0fc198c4908e98d7aae2a76bd78fa004e9c21cb0be7582e36008b4941169f18e], posing in controlnet with posex and openpose, and some prompt experimentation

btw, i'm having another issue where clicking on an image doesn't open it up like it should, just stays in grid view. any ideas on why this is?

AlUlkesh commented 1 year ago

Thanks 😄

btw, i'm having another issue where clicking on an image doesn't open it up like it should, just stays in grid view. any ideas on why this is?

Yes, that's the effect you get when you have the automatic height set with Gradio < 3.39. Check that setting again.

Kapowpenguin1 commented 1 year ago

i updated gradio, and that seems to have fixed the image preview issue, but toggling automatic height actually ended up causing another issue. this is what happens with automatic height enabled image and this is when it's disabled image automatic height seems to make the margins a lot bigger than they should be

edit: i actually just realized that, as long as i don't use automatic height, i don't need to update gradio- so i don't have to worry about changing the gradio version every time i git pull

AlUlkesh commented 1 year ago

i actually just realized that, as long as i don't use automatic height, i don't need to update gradio

Yes, exactly, sorry if I wasn't clear on that.

btw the a1111 dev branch is on 3.39, so it shouldn't take too long for the main branch to follow.

I think the effect you saw with the "margins" is because the usable frame is larger with auto height and so the "center" is lower. I don't think that's easily adjustable, since the way the Gradio gallery works, all the thumbnails from the thumbnail view are still there, just hidden.

Kapowpenguin1 commented 1 year ago

good to know- anyways, appreciate you helping me out again-