Closed jbrazeau closed 10 months ago
Performance improvements yesterday were indeed affecting IN and NOT IN, so it seems something was missed in the unit test coverage. I did add a similar test though, so not sure what causes it yet. I might investigate next week.
Probably related to using ?
as using direct data assignments worked in the unit test.
@jbrazeau i have been able to reproduce and confirmed that my PR is indeed causing the regression. I will let you know once i have a fix.
@jbrazeau see related PR which should fix it.
Thank you very much for paying attention to that issue.
I've checked out the PR, built alasql and manually "patched" dist/alasql.fs.js
in my node_modules
folder (after having installed alasql@4.2.0
). I confirm that the regression seems to disappears ! 👍
I would propose merging this and release as 4.2.1. We can check to re-add the cache layer for the Set later, now we have added more unit test coverage.
Released as part of 4.2.1
I've upgraded alasql (4.1.10 -> 4.2.0) this morning and faced a regression.
I've isolated the problem in a trivial test available in the following git repository : https://gitlab.com/jean-francois.brazeau/alasql-bug-4.2.0
The repository contains a very basic test that :
in
keywordSimply run :
go-4.1.11.sh
to installalasql@4.1.11
and successfully run the test.go-4.2.0.sh
to installalasql@4.2.0
and notice that the query returns no result at the end of the script.